New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace some TODO items with issue ids #9596
refactor: Replace some TODO items with issue ids #9596
Conversation
@@ -6,7 +6,6 @@ const content = loadFixture(__filename, 'travis.yml'); | |||
describe(getName(__filename), () => { | |||
describe('updateDependency', () => { | |||
it('updates values', () => { | |||
// TODO: should be `Upgrade` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -20,7 +20,6 @@ export function updateDependency({ | |||
quote = ''; | |||
} | |||
let newString = `node_js:\n`; | |||
// TODO: `newValue` is a string! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like "bad candies" accompany our New Year celebration being left intact during Christmas, the remaining TODO items look hard for me to formalize. Therefore, this PR is ready for review. |
What do you think about meaning the description in place and a short issue number after it (eg |
ae2b13b
to
92b3d46
Compare
🎉 This PR is included in version 25.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Nothing should be changed
Context:
This PR covers TODOs that aren't related to type issues.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: